Add checkpoint to UNIXSocketStream.aclose and _TrioSocketMixin.aclose - #1292
Add checkpoint to UNIXSocketStream.aclose and _TrioSocketMixin.aclose#1292Mukller wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
|
I am closing this as it's duplicate of #1289 A couple of points:
|
|
It's bad enough that we get AI bots flooding us with duplicate PRs, but then they get confused about their own errors? |
|
Maybe we should update AGENTS.md and/or contributing.rst so these agents actually care about the instructions? Though I doubt these AI bots would care unless the operator points them to it. |
Update, how? They already have explicit instructions to follow the rules in the PR template:
|
|
It's a tricky one. I was looking for inspiration from other projects, but every now and then, agents seem to just erase the PR template. Well, some projects like zizmor go the extra mile and auto-close PRs that don't follow the template. d137692 looks like the nudge I was also thinking about 👍 |
3 participants
Fixes #1288
Summary
_RawSocketMixin.aclose()\ (asyncio) and _TrioSocketMixin.aclose()\ (trio) contained no await points, so calling them inside a cancelled scope never delivered the cancellation to the caller. Every other \�close()\ in both backends already ends with a checkpoint — these two were the only ones missing it.
Changes
The 30 pre-existing test failures in this PR are also present on master (UNIX socket tests are skipped on Windows CI; the Linux matrix failures match the baseline).